Clean up code, improve test coverage and expose /proc/ reading code publicly#7
Clean up code, improve test coverage and expose /proc/ reading code publicly#7timthelion wants to merge 18 commits into
Conversation
there's probably no better way https://github.com/shemminger/iproute2/blob/main/misc/ss.c#L651
jabedude
left a comment
jabedude
left a comment
There was a problem hiding this comment.
Changes look really good! Thanks for taking the time to help out. I had one tiny spelling nit
|
Thanks for catching that. I applied the change and all checks are passing. |
|
Anything else that needs to be done to get this merged? |
|
Just realized that POSIX uses signed i32s for Pids. So I switched over so that it is easy to use this with, for example, the nix package ;) https://docs.rs/nix/0.25.0/nix/pty/type.SessionId.html |
jabedude
left a comment
jabedude
left a comment
There was a problem hiding this comment.
LGTM, thank you very much for the changes
|
Looks like a test failure related to your latest commit |
In POSIX, pids are signed. Negative pids (at least historically), belonged to kernel processes. https://unix.stackexchange.com/questions/150978/process-ids-range
|
Yeah, I think I fixed the tests now. Sorry about that. It turns out that things are a bit more complicated with the |
|
tests::test_symlink_basic 106 is failing |
2 participants
No description provided.