Add action builder#203
Open
gonzaponte wants to merge 3 commits into
Open
Conversation
Owner
|
You've caught me in a bad week ... or two. I won't be able to give this the attention it deserves for a while. Is it urgent? |
Collaborator
Author
|
Not at all. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A partial implementation of #30. The idea is simple: create a more comfortable interface for setting actions. A complete configuration would look like:
But all of these actions are optional.
In this implementation, it was quite natural to include another perk: the possibility of combining multiple actions of the same kind. In my experience, this can be quite useful. It allows the user to create small, well-defined functions that do something very specific, very clearly. Giving these functions meaningful names can result in a self-explanatory workflow. For instance:
The current implementation does not allow for classes to be passed to this builder, but I believe it is feasible to implement a version that does. In any case, I first wanted to hear your thoughts (@jacg) on the current approach, if you have any.