Skip to content

🧹 refactor: use testutil.TestdataPath in users module tests#150

Merged
jackby03 merged 1 commit intomainfrom
refactor/use-testutil-in-users-module-7464997786048593753
Apr 14, 2026
Merged

🧹 refactor: use testutil.TestdataPath in users module tests#150
jackby03 merged 1 commit intomainfrom
refactor/use-testutil-in-users-module-7464997786048593753

Conversation

@jackby03
Copy link
Copy Markdown
Owner

🎯 What: Removed local tdPath utility in internal/modules/users/module_test.go and refactored tests to use the shared testutil.TestdataPath from github.com/hardbox-io/hardbox/internal/modules/util/testutil.
💡 Why: Reduces duplicate path-resolving logic and improves consistency across the codebase testing utilities, in-line with the ongoing effort to consolidate test data path access methods (which already affected logging and auditd test modules).
Verification: Verified by running go fmt ./internal/modules/users, resolving compilation errors from removed tdPath functions, and running the make test test suite and standard Go tests to ensure that the code behaves correctly without functionally altering test results.
Result: A more maintainable and cleaner tests infrastructure for internal/modules/users.


PR created automatically by Jules for task 7464997786048593753 started by @jackby03

Co-authored-by: jackby03 <70082129+jackby03@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@jackby03 jackby03 merged commit bf3f007 into main Apr 14, 2026
12 checks passed
@jackby03 jackby03 deleted the refactor/use-testutil-in-users-module-7464997786048593753 branch April 14, 2026 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant