Conversation
Co-authored-by: jackby03 <70082129+jackby03@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
🎯 What: Removed local
tdPathutility ininternal/modules/users/module_test.goand refactored tests to use the sharedtestutil.TestdataPathfromgithub.com/hardbox-io/hardbox/internal/modules/util/testutil.💡 Why: Reduces duplicate path-resolving logic and improves consistency across the codebase testing utilities, in-line with the ongoing effort to consolidate test data path access methods (which already affected
loggingandauditdtest modules).✅ Verification: Verified by running
go fmt ./internal/modules/users, resolving compilation errors from removedtdPathfunctions, and running themake testtest suite and standard Go tests to ensure that the code behaves correctly without functionally altering test results.✨ Result: A more maintainable and cleaner tests infrastructure for
internal/modules/users.PR created automatically by Jules for task 7464997786048593753 started by @jackby03