fix: reap completed process pool workers#243
Open
MTG-Thomas wants to merge 4 commits into
Open
Conversation
Contributor
Author
|
Updated the PR to cover the clean-exit/result-delivery race that showed up in E2E. The new commit adds a short grace period for exit_code=0 workers whose result pipe has not delivered yet, while preserving the crash path after the grace period. Verification:
|
jackmusick
approved these changes
May 16, 2026
Owner
jackmusick
left a comment
There was a problem hiding this comment.
Reaping logic and grace-window are well-scoped. Verified locally: full unit suite (3777) passes on the branch, including the 5 new regression tests pinning the clean-exit + queued-result race and the zombie-reap path. Important fix for on-demand mode as we lean on it harder for Chat V2 sandboxes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
python3 -m py_compile src/services/execution/process_pool.py tests/unit/execution/test_process_pool.pyPYTHONPATH=$PWD/api pytest api/tests/unit/execution/test_process_pool.py -q -k "PidWrapper or reaps_completed_child or queued_result or crash_detection_replaces_process or sigkilled_worker"(7 passed)Note: the full
test_process_pool.pyrun reached 42/43 in my ad hoc WSL venv; the remaining failure is an existing admission-control test trying to resolveredis:6379without the compose test environment.