Skip to content

feat: solutions chapter 2#2

Open
jacksjm wants to merge 4 commits intomasterfrom
feature/chapter2
Open

feat: solutions chapter 2#2
jacksjm wants to merge 4 commits intomasterfrom
feature/chapter2

Conversation

@jacksjm
Copy link
Owner

@jacksjm jacksjm commented Oct 2, 2020

Solutions for Chapter 2

cc @vrom911 @chshersh

Copy link

@chshersh chshersh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very neat solutions! And congrats with nailing the Advanced Task! πŸ†

Your pattern-matching skills are great! I only left a few minor comments πŸ™‚

@jacksjm
Copy link
Owner Author

jacksjm commented Oct 3, 2020

@chshersh if it's possible you review again

Copy link

@chshersh chshersh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jacksjm Nice solutions! I think this ready for merge 🏁

@chshersh
Copy link

chshersh commented Oct 3, 2020

⚠️ By the way, per new rules of the Hacktoberfest event, you would need to add the hacktoberfest topic to this fork repo:

All previous contributions are legit, but from now on it should have the label to participate.

@jacksjm jacksjm added the hacktoberfest-accepted Accepted for hacktoberfest, will merge later label Oct 3, 2020
@jacksjm
Copy link
Owner Author

jacksjm commented Oct 4, 2020

⚠️ By the way, per new rules of the Hacktoberfest event, you would need to add the hacktoberfest topic to this fork repo:

All previous contributions are legit, but from now on it should have the label to participate.

@chshersh I do It, is ok?

@jacksjm jacksjm closed this Oct 4, 2020
@jacksjm jacksjm reopened this Oct 4, 2020
@chshersh
Copy link

chshersh commented Oct 4, 2020

@jacksjm Yes, you've added the topic correctly πŸ‘Œ

Btw, you can always double-check your contribution status in your profile on the Hacktoberfest website:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest-accepted Accepted for hacktoberfest, will merge later

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants