Skip to content

test(download): retry media-download Windows tests to absorb runner cold-start variance #1708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Benjamin-eecs wants to merge 2 commits into
base: main
Choose a base branch
from
Open

test(download): retry media-download Windows tests to absorb runner cold-start variance #1708

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
430d7b6
test(download): retry media-download Windows tests to absorb runner c…
Benjamin-eecs May 21, 2026
8abcaed
test(download): trim media-download retry comment to match sibling tone
Benjamin-eecs May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/download/media-download.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,9 @@ async function startServer(handler: http.RequestListener): Promise<string> {
return `http://127.0.0.1:${address.port}`;
}

describe('media downloads', () => {
// Windows runners occasionally exceed the default 5s timeout on the first
// http.createServer + downloadMedia roundtrip (cold-start cost on a loaded VM).
describe('media downloads', { retry: process.platform === 'win32' ? 2 : 0 }, () => {
it('keeps custom filenames inside the output directory', async () => {
const baseUrl = await startServer((_req, res) => {
res.statusCode = 200;
Expand Down
Loading