Add experimental meson.build file#245
Open
danyspin97 wants to merge 1 commit intojacob-carlborg:masterfrom
Open
Add experimental meson.build file#245danyspin97 wants to merge 1 commit intojacob-carlborg:masterfrom
danyspin97 wants to merge 1 commit intojacob-carlborg:masterfrom
Conversation
FFY00
suggested changes
Dec 8, 2019
| project('dstep', 'd', version: '1.0.1') | ||
|
|
||
| if get_option('buildtype') == 'release' | ||
| add_project_arguments('-O3', language: 'd') |
There was a problem hiding this comment.
This is wrong. A project should never make this kind of decisions if not required.
danyspin97
force-pushed
the
mesonbuild
branch
from
c10fa04 to
df3174e
Compare
FFY00
approved these changes
Dec 8, 2019
FFY00
left a comment
FFY00
left a comment
There was a problem hiding this comment.
Seems fine. Perhaps there could be a better way to do the clang stuff but I don't have time to investigate.
Author
|
The current method uses llvm-config, which can also be configured when cross compiling according to the system. |
Owner
|
I don't think I want to have an additional build system. What's the reason for adding another one? |
|
Dub is notoriously bad, especially when it comes to software distribution. Having a build system that actually supports pkgconf properly is very important IMO. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.