Sim slopes#84
Open
Imane-code-ux wants to merge 5 commits intojacob-long:masterfrom
Open
Conversation
Author
|
After implementing some changes, I conducted tests using scenarios where a vcov matrix is supplied by the user.The function now correctly utilizes the provided vcov without conflicts, and the errors observed in the initial test case are resolved. |
katossky
reviewed
Apr 13, 2025
There was a problem hiding this comment.
This file should not be included, please remove and push to your own branch (Imane-code-ux:sim_slopes). This should update the present pull request.
|
Can you provide code that you used for tests showing that your solution indeed works ? You can post them here or in the original issue #81. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After implementing some changes, I conducted tests using scenarios where a vcov matrix is supplied by the user.The function now correctly utilizes the provided vcov without conflicts, and the errors observed in the initial test case are resolved.