Detect dangerous reference changes in TryDeserialize()#171
Open
francoisvn wants to merge 1 commit intojacobdufault:masterfrom
Open
Detect dangerous reference changes in TryDeserialize()#171francoisvn wants to merge 1 commit intojacobdufault:masterfrom
francoisvn wants to merge 1 commit intojacobdufault:masterfrom
Conversation
… cyclic references
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's easy to accidentally do something like
instance = new Thing()inTryDeserialize(), but that can break silently if you have any cyclic references. This will try to detect that and complain.Should this be a warning instead of failure? If there are any cyclic references then it could be a nasty silent failure, but if not then there's no issue. Only doing the detection if
IsObjectDetection()would severely limit the coverage of this test, but maybe that could determine warning vs failure? Feels like I might be overthinking, so submitting this for now.Maybe a kinder soul will write a unit test for this. Not sure I'm that soul