fix(ga4): be robust against missing navigator.sendBeacon#57
Open
voidus wants to merge 1 commit intojahilldev:mainfrom
Open
fix(ga4): be robust against missing navigator.sendBeacon#57voidus wants to merge 1 commit intojahilldev:mainfrom
voidus wants to merge 1 commit intojahilldev:mainfrom
Conversation
This was referenced Mar 16, 2025
jahilldev
approved these changes
Apr 3, 2025
Owner
There was a problem hiding this comment.
Thanks for the contribution, @voidus 👍
As discussed in the linked issue, if you have time, could we add a fallback method using fetch with keepalive: true so that we're still recording metrics.
Something simple like this should do:
const queryParams = getQueryParams(trackingId, { type, event, debug });
const endpoint = window.minimalAnalytics?.analyticsEndpoint || analyticsEndpoint;
if(navigator.sendBeacon) {
navigator.sendBeacon(`${endpoint}?${queryParams}`);
} else {
fetch(`${endpoint}?${queryParams}`, {
method: 'POST',
keepalive: true
});
}
bindEvents(trackingId);
trackCalled = true;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #56.
For a more radical approach, see #58