WIP: added novisim as metadata flag for h5 files#43
Open
Conversation
For h5 files that are not related to novisim, the attribute "novisim" will have value 0, or otherwise 1. This avoids checks being hardcoding during the processing steps. There also seems to be an error in the string recieved for meta["ByteOrder"] which contains a whitespace and a semicolon. For now the quick fix was to strip the string and keep only the first part.
carljohnsen
requested changes
Oct 25, 2024
carljohnsen
approved these changes
Oct 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addition requires a test before merge!!!
Currently
processing_steps/0100_cache_esrf2013.pyandprocessing_steps/0200_generate_byte_hdf5.pycan only be run using a special file located on James' ERDA directory.This branch contains two simple additions, that need to be tested/verified:
novisim. For h5 files that are not related to novisim, the attribute will have value0, or otherwise1. This avoids various checks in subsequent processing steps being hardcoded.lib/py/esrf_read.pyin the functionesrf_edf_metadata(), there also seems to be an error in the string received for meta["ByteOrder"] which contains a whitespace and a semicolon. For now the quick fix was to strip the string and keep only the first part.