Skip to content

Exclude web/.gitkeep from PyPI wheel distribution #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamesbconner merged 1 commit into from
Feb 22, 2026
Merged

Exclude web/.gitkeep from PyPI wheel distribution #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [1.3.3] - 2026-02-22

### Fixed

- **PyPI wheel packaging**: Fixed duplicate `.gitkeep` file in wheel that caused PyPI upload rejection. Changed wheel build configuration to use `only-include` for Python files, preventing the `.gitkeep` placeholder from being included via the `packages` directive while still allowing it through `force-include`.

## [1.3.2] - 2026-02-22

### Fixed
Expand Down
5 changes: 5 additions & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,11 @@ path = "src/SVG2DrawIOLib/__about__.py"

[tool.hatch.build.targets.wheel]
packages = ["src/SVG2DrawIOLib"]
only-include = [
"SVG2DrawIOLib/**/*.py",
"SVG2DrawIOLib/**/*.typed",
"SVG2DrawIOLib/py.typed",
]
Copy link
Copy Markdown

@cursor cursor bot Feb 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only-include does not support glob patterns

High Severity

The only-include directive in hatchling only accepts explicit paths to directories or files — it does not support glob patterns. The entries SVG2DrawIOLib/**/*.py and SVG2DrawIOLib/**/*.typed use glob syntax (**/*), which only-include will not resolve. This likely causes the wheel to contain no Python source files at all (only the force-include web directory), producing a completely broken package. The include option supports globs, but only-include does not.

Fix in Cursor Fix in Web

Copy link
Copy Markdown

@cursor cursor bot Feb 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only-include paths missing required src/ prefix

High Severity

The only-include paths reference SVG2DrawIOLib/... but the actual source files live at src/SVG2DrawIOLib/... relative to the project root. Because only-include takes precedence over packages, the path-collapsing behavior of packages = ["src/SVG2DrawIOLib"] is lost. Even if the glob pattern issue were fixed, these paths would still not resolve to any files on disk since the src/ prefix is missing.

Fix in Cursor Fix in Web


[tool.hatch.build.targets.wheel.force-include]
"src/SVG2DrawIOLib/web" = "SVG2DrawIOLib/web"
Expand Down
2 changes: 1 addition & 1 deletion src/SVG2DrawIOLib/__about__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
"""Package version information."""

__version__ = "1.3.2"
__version__ = "1.3.3"