Simplify wheel build configuration and bump version to 1.3.4#37
Simplify wheel build configuration and bump version to 1.3.4#37jamesbconner merged 1 commit intomainfrom
Conversation
- Remove `only-include` directive from pyproject.toml wheel build config that was unnecessarily restricting file inclusion - Simplify `build-release` Makefile target to remove `.gitkeep` preservation logic since placeholder is not needed in distribution builds - Clear `.gitkeep` file content as it's only required for development and editable installs - Update version to 1.3.4 in __about__.py - Update CHANGELOG.md with release notes documenting the build configuration fixes The `only-include` directive was causing CI/CD issues by conflicting with the `force-include` directive for web artifacts. Removing it allows the standard wheel build process to work correctly while still including the necessary web UI files through `force-include`.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| packages = ["src/SVG2DrawIOLib"] | ||
| only-include = [ | ||
| "SVG2DrawIOLib/**/*.py", | ||
| "SVG2DrawIOLib/**/*.typed", |
There was a problem hiding this comment.
Removing only-include reintroduces duplicate wheel file entries
Medium Severity
Removing only-include while keeping force-include for the same web directory reintroduces the duplicate file issue fixed in v1.3.3. The empty .gitkeep file is explicitly un-ignored in .gitignore (!src/SVG2DrawIOLib/web/.gitkeep), so packages discovers it, while force-include also includes it — creating a duplicate entry in the wheel. Hatchling has a documented issue where overlapping force-include and packages paths produce invalid wheels with duplicate entries that fail PyPI upload. This only affects builds without running build-release first (which deletes .gitkeep), but matches the exact regression from v1.3.2.
Additional Locations (1)
2 participants
only-includedirective from pyproject.toml wheel build config that was unnecessarily restricting file inclusionbuild-releaseMakefile target to remove.gitkeeppreservation logic since placeholder is not needed in distribution builds.gitkeepfile content as it's only required for development and editable installsonly-includedirective was causing CI/CD issues by conflicting with theforce-includedirective for web artifacts. Removing it allows the standard wheel build process to work correctly while still including the necessary web UI files throughforce-include.Note
Low Risk
Packaging/build-script changes only; risk is limited to release/wheel contents and CI build behavior.
Overview
Updates the release packaging to fix CI/PyPI wheel build issues by removing Hatch wheel
only-includerestrictions while continuing to bundle the web UI viaforce-include.Simplifies the
Makefilebuild-releaseflow by removing.gitkeeppreservation and clears the tracked.gitkeepplaceholder content, then bumps the library version to1.3.4and documents the release inCHANGELOG.md.Written by Cursor Bugbot for commit 1bf36ee. This will update automatically on new commits. Configure here.