Merged
Conversation
…rmance function - Streamline the comparison logic by removing redundant variable assignments. - Enhance clarity by directly using the SnapshotPerformanceAnalyzer for performance comparisons. - Maintain functionality while improving code readability and maintainability.
- Add path resolution for relative local filesystem paths to absolute posix paths - Fix stale current-snapshot-id by patching metadata.json to target snapshot - Lowercase file_format in delete manifests to work around DuckDB iceberg_scan bug - Rename _patch_file_format_in_record to _patch_manifest_record for clarity - Rename _patch_delete_manifest to _patch_manifest with is_delete parameter - Simplify logging and remove per-manifest format change counters - Update module docstring to document all three DuckDB workarounds - Update web/index.html with minor formatting changes
- Upgrade ruff from v0.7.4 to v0.15.2 for improved linting capabilities - Upgrade mypy from v1.13.0 to v1.19.1 for enhanced type checking - Upgrade pre-commit-hooks from v5.0.0 to v6.0.0 for latest hook improvements - Upgrade bandit from 1.7.10 to 1.9.3 for improved security scanning - Add nosec B105 comment to suppress false positive hardcoded password warning - Reformat assertion in test to improve readability and comply with updated linting rules
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Touches Iceberg metadata/manifest rewriting logic used by DuckDB scans; path normalization and snapshot-id forcing could change which files are read or how local tables resolve paths (especially on Windows). Other changes are low risk (lint/tool bumps and a small delta-compare control-flow fix).
Overview
Improves Iceberg snapshot patching for DuckDB/GizmoSQL comparisons by rewriting temp
metadata.jsonto forcecurrent-snapshot-idto the target snapshot and normalizing relative local paths to absolute posix paths across manifest lists and manifests (in addition to lowercasing delete-manifestfile_format). It now processes all manifests (data + delete) and rewrites the manifest-list whenever patched manifests exist or relative paths are present.Fixes the
/gizmosql/comparedelta path to immediately run the performance analyzer forver_avsver_b(removing unreachable shared logic), and silences Bandit’s hardcoded-password warning forTABLESLEUTH_GIZMO_PASSWORDinconfig-check.Bumps pre-commit hook versions (
ruff,mypy,pre-commit-hooks,bandit) and updates the generatedweb/index.htmlartifact (build hash).Written by Cursor Bugbot for commit e7c41f6. This will update automatically on new commits. Configure here.