This repository was archived by the owner on Nov 2, 2022. It is now read-only.
Removes array_filter callable to use array_filter default behaviour#77
Open
TuzBot wants to merge 1 commit intojamesryanbell:masterfrom
Open
Removes array_filter callable to use array_filter default behaviour#77TuzBot wants to merge 1 commit intojamesryanbell:masterfrom
TuzBot wants to merge 1 commit intojamesryanbell:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default array_filter removes any null entries when filtering through an array, which means the callback is not needed.
Than being said, for those that don't know array_filters default behaviour the written code with the callback shows its intent a bit clearer along with the comment.