Add twentytwenty library to use in shots comparison#9
Open
mahmoudfelfel wants to merge 3 commits intojamesryanbell:masterfrom
Open
Add twentytwenty library to use in shots comparison#9mahmoudfelfel wants to merge 3 commits intojamesryanbell:masterfrom
mahmoudfelfel wants to merge 3 commits intojamesryanbell:masterfrom
Conversation
Owner
|
Thanks for this it looks good. The build seems to be failing due to an error in the package.json file, can you review the changes and fix the issue please so I can look at merge the pull request. Thanks |
Contributor
Author
|
Thanks @jamesryanbell i have fixed it, you can merge now. |
Owner
|
Hi Finally managed to get some time to test this out! It works and looks really great but there is a small bug. After the first dragging of the slider on the before and after image the height of the before and after container is reduced to the height of the page. This means you can no longer scroll down the image. Thanks, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add twentytwenty jquery plugin to use it for image comparison, as sometimes the diffs are simple and the one who testing can't notice them, so it is better to compare everything on one full-page view.

hint: i just made it work, the implementation is just css and plain jquery in gallery.html, i'm intending to enhance this later!