Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 0 additions & 67 deletions .github/workflows/codeql-analysis.yml

This file was deleted.

2 changes: 1 addition & 1 deletion CODEOWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
# the repo. Unless a later match takes precedence,
# @global-owner1 and @global-owner2 will be requested for
# review when someone opens a pull request.
* @wandera/datascience
* @jamf/data-science

# Order is important; the last matching pattern takes the most
# precedence. When someone opens a pull request that only
Expand Down
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,11 @@ For more information on how we write our markdown files, see [the GitHub Markdow

#### Create a new issue

If you spot a problem with the docs, [search if an issue already exists](https://docs.github.com/en/github/searching-for-information-on-github/searching-on-github/searching-issues-and-pull-requests#search-by-the-title-body-or-comments). If a related issue doesn't exist, you can open a new issue using a relevant [issue form](https://github.com/wandera/1password-client/issues/new/choose).
If you spot a problem with the docs, [search if an issue already exists](https://docs.github.com/en/github/searching-for-information-on-github/searching-on-github/searching-issues-and-pull-requests#search-by-the-title-body-or-comments). If a related issue doesn't exist, you can open a new issue using a relevant [issue form](https://github.com/jamf/1password-client/issues/new/choose).

#### Solve an issue

Scan through our [existing issues](https://github.com/wandera/1password-client/issues) to find one that interests you. You can narrow down the search using `labels` as filters. As a general rule, we don’t assign issues to anyone. If you find an issue to work on, you are welcome to open a PR with a fix.
Scan through our [existing issues](https://github.com/jamf/1password-client/issues) to find one that interests you. You can narrow down the search using `labels` as filters. As a general rule, we don’t assign issues to anyone. If you find an issue to work on, you are welcome to open a PR with a fix.

### Make Changes

Expand Down
3 changes: 1 addition & 2 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
# OnePassword python client
[![PyPi release](https://github.com/wandera/1password-client/actions/workflows/publish-to-pypi.yml/badge.svg?branch=main&event=push)](https://github.com/wandera/1password-client/actions/workflows/publish-to-pypi.yml)
[![CodeQL](https://github.com/wandera/1password-client/actions/workflows/codeql-analysis.yml/badge.svg)](https://github.com/wandera/1password-client/actions/workflows/codeql-analysis.yml)
[![PyPi release](https://github.com/jamf/1password-client/actions/workflows/publish-to-pypi.yml/badge.svg?branch=main&event=push)](https://github.com/jamf/1password-client/actions/workflows/publish-to-pypi.yml)

Python client around the 1Password password manager cli for usage within python code and
Jupyter Notebooks. Developed by Data Scientists from Jamf.
Expand Down
18 changes: 9 additions & 9 deletions onepassword/client.py
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ class ManualSignIn(SignIn):
"""
Class to sign in to 1Password manually, see: https://developer.1password.com/docs/cli/sign-in-manually

:param account: Shorthand account name for your 1Password account e.g. wandera from wandera.1password.com.
:param account: Shorthand account name for your 1Password account e.g. jamf from jamf.1password.com.
(Optional, default = None)
:param password: 1Password password. (Optional, default = None)
"""
Expand Down Expand Up @@ -129,9 +129,9 @@ def signin_wrapper(
Helper function for user to sign in but allows for three incorrect passwords. If successful signs in and updates
bash profile, if not raises exception and points user to 1Password support.

:param account: Shorthand account name for your 1Password account e.g. wandera from wandera.1password.com.
:param account: Shorthand account name for your 1Password account e.g. jamf from jamf.1password.com.
(Optional, default = None)
:param domain: Full domain name of 1Password account e.g. wandera.1password.com (Optional, default=None)
:param domain: Full domain name of 1Password account e.g. jamf.1password.com (Optional, default=None)
:param email: Email address of 1Password account (Optional, default=None)
:param secret_key: Secret key of 1Password account (Optional, default=None)
:param master_password: Password for 1Password account (Optional, default=None)
Expand Down Expand Up @@ -163,9 +163,9 @@ def signin(
"""
Helper function to prepare sign in for the user

:param account: Shorthand name for your 1Password account e.g. wandera from wandera.1password.com
:param account: Shorthand name for your 1Password account e.g. jamf from jamf.1password.com
(Optional, default=None)
:param domain: Full domain name of 1Password account e.g. wandera.1password.com (Optional, default=None)
:param domain: Full domain name of 1Password account e.g. jamf.1password.com (Optional, default=None)
:param email: Email address of 1Password account (Optional, default=None)
:param secret_key: Secret key of 1Password account (Optional, default=None)
:param master_password: Password for 1Password account (Optional, default=None)
Expand All @@ -192,8 +192,8 @@ def signin(
session_dict = bp.get_key_value(self._env_session, fuzzy=True)[0] # list of dicts from BashProfile
account = list(session_dict.keys())[0].split(self._env_session + "_")[1]
except AttributeError:
account = input("Please input your 1Password account name e.g. wandera from "
"wandera.1password.com: ")
account = input("Please input your 1Password account name e.g. jamf from "
"jamf.1password.com: ")
except ValueError:
raise ValueError("First signin failed or not executed.")

Expand All @@ -207,7 +207,7 @@ class AppSignIn(SignIn):
Class to sign in to 1Password using the 1Password app integration,
see: https://developer.1password.com/docs/cli/app-integration

:param account: Shorthand account name for your 1Password account e.g. wandera from wandera.1password.com.
:param account: Shorthand account name for your 1Password account e.g. jamf from jamf.1password.com.
(Optional, default = None)
"""
def __init__(self, account: str | None = None) -> None:
Expand Down Expand Up @@ -243,7 +243,7 @@ def signin(self, account: str | None = None) -> None:
"""
Sign in to your 1Password account using the app integration

:param account: Shorthand account name for your 1Password account e.g. wandera from wandera.1password.com.
:param account: Shorthand account name for your 1Password account e.g. jamf from jamf.1password.com.
(Optional, default = None)
"""
bash_profile = BashProfile()
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ def readme():
],
python_requires='>=3.7',
license="MIT",
url="https://github.com/wandera/1password-client",
url="https://github.com/jamf/1password-client",
classifiers=["Programming Language :: Python :: 3 :: Only",
"License :: OSI Approved :: MIT License",
"Operating System :: MacOS :: MacOS X",
Expand Down
Loading