Open
Conversation
This change adds support for specifying memory limits in megabytes when creating a new machine via the CLI. The API already had support for this parameter, but it was not exposed in the command-line interface. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
rolyatmax
reviewed
Apr 4, 2025
| #[arg(long = "tag", value_parser = parse_key_val, action = clap::ArgAction::Append)] | ||
| tags: Option<Vec<(String, String)>>, | ||
|
|
||
| /// Memory size in MB (if not specified, a default value will be used) |
Member
There was a problem hiding this comment.
Worth saying what the default is? Or is that risky in case it changes later?
rolyatmax
approved these changes
Apr 4, 2025
Member
rolyatmax
left a comment
rolyatmax
left a comment
There was a problem hiding this comment.
Small comment, no blockers. LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds support for specifying memory limits in megabytes when creating a new machine via the CLI. The API already had support for this parameter, but it was not exposed in the command-line interface.
🤖 Generated with Claude Code
Co-Authored-By: Claude