Type hints, optional sparse output, stdin as input#7
Open
elonen wants to merge 2 commits intojancc:masterfrom
Open
Type hints, optional sparse output, stdin as input#7elonen wants to merge 2 commits intojancc:masterfrom
elonen wants to merge 2 commits intojancc:masterfrom
Conversation
|
Great, both sparseness and supporting pipes are very welcome additions. Worked for me. Something as simple as: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements several improvements:
/dev/stdin(e.g. zstdcat pipe) as an input (fixes FR. Using stdin as input #3)It has so far always produced identical output to the original PVE
vmacommand, but it's really hard to be 100% sure as the VMA format unfortunately doesn't have checksums for the device image contents, only the file headers.