Skip to content

Add ruby 4.0 #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
janko merged 6 commits into from
Feb 23, 2026
Merged

Add ruby 4.0 #102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fa65925
Add latest ruby
makrsmark Feb 19, 2026
305270f
pinning httpx to prevent failures
makrsmark Feb 19, 2026
2755c21
build fix
makrsmark Feb 19, 2026
bbfeba9
back to pinning
makrsmark Feb 19, 2026
02ad09a
fix missing revert
makrsmark Feb 19, 2026
ed0cc80
fix
makrsmark Feb 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,13 @@ jobs:
fail-fast: false
matrix:
ruby:
- "2.4"
- "2.5"
- "2.6"
- "2.7"
- "3.0"
- "3.1"
- "3.2"
- "3.3"
- "3.4"
- "4.0"
- "jruby-9.4"

services:
Expand Down
7 changes: 4 additions & 3 deletions down.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Gem::Specification.new do |spec|
spec.name = "down"
spec.version = Down::VERSION

spec.required_ruby_version = ">= 2.4"
spec.required_ruby_version = ">= 2.7"

spec.summary = "Robust streaming downloads using Net::HTTP, http.rb or HTTPX."
spec.homepage = "https://github.com/janko/down"
Expand All @@ -16,12 +16,13 @@ Gem::Specification.new do |spec|
spec.require_path = "lib"

spec.add_dependency "addressable", "~> 2.8"
spec.add_dependency "base64", "~> 0.3"

spec.add_development_dependency "minitest", "~> 5.8"
spec.add_development_dependency "mocha", "~> 1.5"
spec.add_development_dependency "rake"
spec.add_development_dependency "httpx", RUBY_VERSION >= "2.7" ? "~> 1.0" : "~> 0.24"
spec.add_development_dependency "http", RUBY_VERSION >= "2.5" ? "~> 5.0" : "~> 4.3"
spec.add_development_dependency "httpx", "~> 1.0", "< 1.4.4"
spec.add_development_dependency "http", "~> 5.0"
spec.add_development_dependency "warning"
spec.add_development_dependency "csv"
end
6 changes: 3 additions & 3 deletions lib/down/net_http.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ def download(url, *args, **options)
uri.password = nil
end

open_uri_file = open_uri(uri, open_uri_options, follows_remaining: max_redirects, auth_on_redirect: )
open_uri_file = open_uri(uri, open_uri_options, follows_remaining: max_redirects, auth_on_redirect: auth_on_redirect)

# Handle the fact that open-uri returns StringIOs for small files.
extname = extension ? ".#{extension}" : File.extname(open_uri_file.base_uri.path)
Expand All @@ -117,7 +117,7 @@ def open(url, *args, **options)

# Create a Fiber that halts when response headers are received.
request = Fiber.new do
net_http_request(uri, options, follows_remaining: max_redirects, auth_on_redirect:) do |response|
net_http_request(uri, options, follows_remaining: max_redirects, auth_on_redirect: auth_on_redirect) do |response|
Fiber.yield response
end
end
Expand Down Expand Up @@ -249,7 +249,7 @@ def net_http_request(uri, options, follows_remaining:, auth_on_redirect:, &block
uri.password = nil unless auth_on_redirect
end

net_http_request(location, options, follows_remaining: follows_remaining - 1, auth_on_redirect:, &block)
net_http_request(location, options, follows_remaining: follows_remaining - 1, auth_on_redirect: auth_on_redirect, &block)
end
end

Expand Down
Loading