Exit with code 1 on HTTP errors#187
Open
lamsal27 wants to merge 1 commit into
Open
Conversation
Previously, fetch failures were logged to stderr but the process exited with code 0, making it impossible for wrapper scripts to detect failure. Fixes jarun#83.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an HTTP error occurs (e.g. 403 Forbidden), the error was logged to stderr but the process exited with code 0. This makes it impossible for wrapper scripts to detect failure: ddgr --np search && do_something would always execute do_something regardless of whether the search succeeded.
Changed return None to sys.exit(1) in the fetch_page exception handler.
Fixes #83.