Open
Conversation
Co-authored-by: alegorico <5614357+alegorico@users.noreply.github.com>
Add Oracle Database support
Integrate complete support for Oracle databases in pyway
Added validation for required database fields based on type.
Added multiple tests for Oracle database configuration and connection.
Added a test migration script for Oracle database.
This module provides Oracle database connection configuration for testing PyWay Oracle functionality, including connection initialization and availability checks.
This file contains multiple tests for Oracle database checksums using pytest. It includes tests for valid checksums, invalid filenames, and different authentication methods.
Added tests for Oracle table import functionality with various configurations including wallet authentication and error handling for invalid schema files.
Add tests for Oracle integration using pytest.
Add tests for Oracle migration functionality using pytest.
This file contains multiple tests for validating Oracle database migrations using pytest. It includes tests for successful validation, handling of missing schemas, checksum mismatches, and Oracle Wallet authentication.
Test oracle
Oracle tests patch
Test oracle
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: Add comprehensive Oracle Database support with enterprise authentication
Core Oracle Implementation:
• New Oracle Database client (pyway/dbms/oracle.py) with full CRUD operations
• Oracle-specific SQL schema versioning table with NUMBER and VARCHAR2 types
• Parameterized queries using Oracle bind variables (:version syntax)
• Proper Oracle connection lifecycle management
Advanced Connection Methods:
• Easy Connect strings: host:port/service_name format
• TNS Names resolution for aliases in tnsnames.ora
• Full DSN support for complex connection descriptors
• Oracle Wallet passwordless authentication with auto-detection
• Flexible DSN building with fallback mechanisms
Oracle Client Integration:
• Oracle Thin mode (default) - no client installation required
• Oracle Thick mode with Instant Client library support
• Automatic fallback from Thick to Thin mode on errors
• Configurable Oracle Client library directory (oracle_client_lib_dir)
• TNS_ADMIN environment variable integration
Enterprise Authentication Features:
• Oracle Wallet support with multiple detection methods:
• Traditional username/password authentication
• Robust authentication method validation and error handling
Configuration Enhancements:
• Updated CLI argument parser to include 'oracle' database type
• New Oracle-specific configuration parameters:
• Enhanced main CLI validation for Oracle-specific requirements
• Flexible validation logic for Oracle Wallet vs traditional auth
Documentation & Examples:
• Comprehensive README.md updates with Oracle configuration examples:
• Oracle troubleshooting section with common issues
• Updated environment variables table with Oracle-specific options
• Oracle Client configuration modes documentation
Testing Infrastructure:
• Oracle factory pattern integration test (tests/test_oracle.py)
• Test configuration files for different Oracle scenarios:
• Sample Oracle migration script (test_connector/V01_01__test_connection.sql)
Dependencies & Requirements:
• Added oracledb>=2.0.0 to requirements.txt for Oracle connectivity
• Updated supported databases list to include Oracle Database
Code Quality Improvements:
• Comprehensive error handling with informative messages
• Type hints throughout Oracle implementation
• Consistent code style with existing PyWay database adapters
This implementation provides production-ready Oracle Database support suitable for
enterprise environments with advanced security requirements and multiple deployment scenarios.