Extract inline scripts, add registry OIDC role, clean up#13
Merged
Conversation
Workflow cleanup: - Extract all inline bash/Python from workflows into scripts/ - Replace Python scripts (notify-slack, update-task-def, create-override-token) with shell equivalents using curl, jq, aws CLI - Scripts self-resolve SSM webhook URLs via SSM_WEBHOOK_PARAM env var - Only remaining Python is review-plan.py (Bedrock SDK) - plan-review only alerts Slack on HIGH risk with override link Registry provisioning: - Add javabin-ci-registry OIDC role scoped to lambda:InvokeFunction on team-provisioner (ARN constructed from naming convention) - Delete provision-app.yml (registry invokes Lambda directly now) - Add provision-teams.sh (yq + aws lambda invoke) Housekeeping: - Delete stale repos/ directory (old scaffolding copies) - Delete notify-block.py (replaced by notify-slack.sh) - Update CLAUDE.md
Terraform PlanChanges detected — review required. Plan output |
🧠 LLM Plan ReviewRisk: 🟢 LOW Risk: 🟢 LOW Plan adds a new CI registry role with Lambda invocation permissions and performs routine CloudTrail maintenance with minor S3 lifecycle configuration updates.
|
Alexanderamiri
added a commit
that referenced
this pull request
Mar 8, 2026
Fixes the apply failure from PR #13. CloudTrail resources are in terraform/org/ — the duplicate in monitoring caused a DeleteTrail error blocked by the permission boundary.
Alexanderamiri
added a commit
that referenced
this pull request
May 9, 2026
## Summary - Extract all inline bash/Python from workflows into `scripts/` - Replace Python with shell (curl/jq/aws CLI) everywhere except `review-plan.py` (Bedrock SDK) - Scripts self-resolve SSM webhooks — no more SSM fetches in workflow YAML - Add `javabin-ci-registry` OIDC role so registry invokes team-provisioner Lambda directly - Delete `provision-app.yml` (registry no longer dispatches to platform) - Delete stale `repos/` directory - Plan-review only alerts Slack on HIGH risk with override link ## New scripts | Script | Replaces | |--------|----------| | `notify-slack.sh` | `notify-slack.py`, `notify-block.py`, 4 inline Python blocks | | `check-risk-gate.sh` | inline risk+override logic in tf-apply | | `check-risk-block.sh` | inline risk block logic in platform-ci | | `ecs-deploy.sh` | inline ECS deploy in ecs-deploy.yml | | `update-task-def.sh` | `update-task-def.py` | | `write-override-token.sh` | `create-override-token.py` | | `provision-teams.sh` | `provision-teams.py` | | `drift-check.sh`, `verify-plan.sh`, `run-plan.sh`, `upload-plan.sh` | inline blocks in platform-ci/tf-plan | ## Test plan - [ ] Merge and verify platform CI passes - [ ] Push a team change to registry → verify provision.yml invokes Lambda via new OIDC role
Alexanderamiri
added a commit
that referenced
this pull request
May 9, 2026
Fixes the apply failure from PR #13. CloudTrail resources are in terraform/org/ — the duplicate in monitoring caused a DeleteTrail error blocked by the permission boundary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/review-plan.py(Bedrock SDK)javabin-ci-registryOIDC role so registry invokes team-provisioner Lambda directlyprovision-app.yml(registry no longer dispatches to platform)repos/directoryNew scripts
notify-slack.shnotify-slack.py,notify-block.py, 4 inline Python blockscheck-risk-gate.shcheck-risk-block.shecs-deploy.shupdate-task-def.shupdate-task-def.pywrite-override-token.shcreate-override-token.pyprovision-teams.shprovision-teams.pydrift-check.sh,verify-plan.sh,run-plan.sh,upload-plan.shTest plan