Never update existing Google group metadata#35
Merged
Conversation
Skip PUT /groups/{key} for existing groups to prevent accidentally
renaming or overwriting unrelated groups that share a display name
or alias. Only create new groups; existing ones get member sync only.
Root cause: the Lambda renamed jz-ledelsen@java.no to javazone@java.no
because it matched on the display name during the PUT update.
Terraform PlanChanges detected — review required. Plan output |
LLM Plan ReviewRisk: 🟢 LOW Routine Lambda function update for team_provisioner with source code changes, no infrastructure modifications or security concerns.
|
Alexanderamiri
added a commit
that referenced
this pull request
May 9, 2026
## Summary
Skip `PUT /groups/{key}` for existing groups. Only create new groups;
existing ones get member sync only.
## Why
The Lambda renamed `jz-ledelsen@java.no` to `javazone@java.no` because
it tried to update an existing group's metadata (name, description,
email) via PUT. Google matched the request to the wrong group based on
display name overlap.
## Change
When a group already exists, log it and skip the metadata update. Only
add members.
## Test plan
- [ ] Merge and apply
- [ ] Verify existing groups are not renamed when provision-groups runs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Skip
PUT /groups/{key}for existing groups. Only create new groups; existing ones get member sync only.Why
The Lambda renamed
jz-ledelsen@java.notojavazone@java.nobecause it tried to update an existing group's metadata (name, description, email) via PUT. Google matched the request to the wrong group based on display name overlap.Change
When a group already exists, log it and skip the metadata update. Only add members.
Test plan