Skip redundant force-deploy when tf-apply already triggered a rollout#52
Merged
Conversation
If tf-apply updated the ECS service (e.g. new task def), a deployment is already in progress. Forcing another one doubles the wait time. Now checks deployment count first — only forces if no rollout is active.
Terraform PlanNo changes — infrastructure is up to date. Plan output |
Alexanderamiri
added a commit
that referenced
this pull request
May 9, 2026
…#52) ## Summary When tf-apply updates the ECS service (new task def revision), ECS already starts a rolling deployment. The ecs-deploy step was then calling `--force-new-deployment` on top of that, causing **two sequential deployments** and doubling the stabilization wait (~5 min instead of ~2 min). Now checks if a deployment is already in progress (deployment count > 1) and skips the force if so. ## Test plan - [ ] Merge and trigger platform-test-app - [ ] When tf-apply runs (has changes): deploy should say "Deployment already in progress, waiting..." and finish in ~2 min - [ ] When tf-apply is skipped (no changes): deploy should force as before
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When tf-apply updates the ECS service (new task def revision), ECS already starts a rolling deployment. The ecs-deploy step was then calling
--force-new-deploymenton top of that, causing two sequential deployments and doubling the stabilization wait (~5 min instead of ~2 min).Now checks if a deployment is already in progress (deployment count > 1) and skips the force if so.
Test plan