Remove actor-based override gating, improve override UX#61
Merged
Conversation
… names CloudTrail event names include version suffixes (e.g. CreateFunction20150331, DeleteFunction20150331) which didn't match the hardcoded names. Using prefix matching (Create*, Delete*, Modify*, etc.) scoped by source service catches all variants without maintaining explicit lists. Fixes missing Slack alerts for Lambda creation/deletion and other resources.
- Remove override_approvers variable and actor condition from ci-override-approver trust policy. Access control is handled by GitHub (repo permissions + CODEOWNERS + environment protection rules), not by AWS IAM username matching. - Move job_workflow_ref to StringLike (consistent with other conditions) - HIGH risk Slack alert now includes a ready-to-copy gh CLI command with all override parameters pre-filled (plan_key, repo, run_id)
Terraform PlanChanges detected — review required. Plan output |
LLM Plan ReviewRisk: 🔴 HIGH Plan exposes password-set Lambda function to public internet with no authentication, creating a critical security vulnerability.
|
Alexanderamiri
added a commit
that referenced
this pull request
May 9, 2026
## Summary - **Remove `override_approvers`** variable and `ForAnyValue:StringEquals` actor condition from the `ci-override-approver` IAM role. GitHub usernames should not be in AWS trust policies — access control is handled by GitHub repo permissions, CODEOWNERS, and environment protection rules. - **HIGH risk Slack alert** now includes a ready-to-copy `gh workflow run` command with all parameters pre-filled (plan_key, repo, run_id), so the user doesn't have to dig through CI logs to find these values. ## Test plan - [ ] Apply removes actor condition from trust policy - [ ] Next HIGH risk plan: Slack message includes the `gh` override command - [ ] Override workflow can be triggered by anyone with repo write access
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
override_approversvariable andForAnyValue:StringEqualsactor condition from theci-override-approverIAM role. GitHub usernames should not be in AWS trust policies — access control is handled by GitHub repo permissions, CODEOWNERS, and environment protection rules.gh workflow runcommand with all parameters pre-filled (plan_key, repo, run_id), so the user doesn't have to dig through CI logs to find these values.Test plan
ghoverride command