Show override values as fields in Slack alert#62
Merged
Conversation
The HIGH risk Slack message now shows plan_key, repository, and run_id as separate fields so they can be copied into the workflow dispatch form.
Terraform PlanChanges detected — review required. Plan output |
LLM Plan ReviewRisk: 🔴 HIGH Plan creates public unauthenticated access to password-set Lambda function, introducing critical security vulnerability.
|
2 tasks
Alexanderamiri
added a commit
that referenced
this pull request
Mar 14, 2026
## Summary `check-risk-block.sh` was unconditionally blocking on HIGH risk with `exit 1` — it never checked whether an override had been signed. The approve-override workflow writes `override.json` to S3, but nothing was reading it. Now checks for `override.json` in the plan bucket before blocking. If an override exists, the apply proceeds. This is why the override workflow succeeded but the retriggered apply still failed. ## Test plan - [ ] Merge → this PR itself will be LOW/MEDIUM risk (no infra changes) → auto-applies - [ ] Re-run the blocked apply from #62 → override.json exists → apply proceeds
Alexanderamiri
added a commit
that referenced
this pull request
May 9, 2026
## Summary Replace the CLI command in the HIGH risk Slack alert with clear fields (plan key, repository, run ID) that can be copied into the workflow dispatch form. ## Test plan - [ ] Next HIGH risk alert shows the three values as separate copyable fields
Alexanderamiri
added a commit
that referenced
this pull request
May 9, 2026
## Summary `check-risk-block.sh` was unconditionally blocking on HIGH risk with `exit 1` — it never checked whether an override had been signed. The approve-override workflow writes `override.json` to S3, but nothing was reading it. Now checks for `override.json` in the plan bucket before blocking. If an override exists, the apply proceeds. This is why the override workflow succeeded but the retriggered apply still failed. ## Test plan - [ ] Merge → this PR itself will be LOW/MEDIUM risk (no infra changes) → auto-applies - [ ] Re-run the blocked apply from #62 → override.json exists → apply proceeds
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the CLI command in the HIGH risk Slack alert with clear fields (plan key, repository, run ID) that can be copied into the workflow dispatch form.
Test plan