Skip to content

Fix check-risk-block to check S3 for override before blocking #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Alexanderamiri merged 1 commit into from
Mar 14, 2026
Merged

Fix check-risk-block to check S3 for override before blocking #63

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions scripts/check-risk-block.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
#!/bin/sh
# Block apply if risk is HIGH or FAILED.
# Block apply if risk is HIGH or FAILED, unless an override exists.
#
# Usage: check-risk-block.sh <risk_level>
#
# Exits 0 if safe to apply, 1 if blocked.
# Slack notification is handled by notify-high-risk.sh in the review step —
# no duplicate alert here.
# On HIGH risk, checks S3 for an override.json signed by the apply-gate Lambda.
# Requires: PLAN_BUCKET, GITHUB_REPOSITORY, GITHUB_RUN_ID env vars.

set -e

Expand All @@ -17,5 +17,15 @@ if [ "$RISK" != "HIGH" ] && [ "$RISK" != "FAILED" ] && [ -n "$RISK" ]; then
exit 0
fi

echo "Auto-apply blocked (risk=${RISK})."
# Check for a signed override in S3
PLAN_PREFIX="plans/${GITHUB_REPOSITORY}/${GITHUB_RUN_ID}"
OVERRIDE_KEY="${PLAN_PREFIX}/override.json"

if aws s3 ls "s3://${PLAN_BUCKET}/${OVERRIDE_KEY}" > /dev/null 2>&1; then
echo "Override found: s3://${PLAN_BUCKET}/${OVERRIDE_KEY}"
echo "Proceeding with HIGH risk apply."
exit 0
fi

echo "Auto-apply blocked (risk=${RISK}). No override found."
exit 1