Improve alerts, email branding, and add password.javazone.no#67
Merged
Conversation
Alert improvements: - Filter service-linked role events (ECS ENI provisioning noise) - Add CI context (actor/repo/sha/run) to team provisioner Slack notifications - Daily cost spikes: add $1 min threshold, usage type + tag breakdown, CE links - Weekly cost report: replace bullet lists with Block Kit tables Email and password-set: - Subject/body: "Velkommen til JavaBin", footer: "Javabrukerforeningen i Norge" - Brand colors: navy #1a1a2e → salmon #f05350 across email + password-set pages - CID-embed logo PNG to avoid Outlook "trust this email" prompt - Route password.javazone.no via ALB to password-set Lambda - Handler supports both ALB and Function URL event formats
Store the javaBin white logo as a PNG in the repo (auditable, viewable). Terraform uses filebase64() to include it in the Lambda zip as a .b64 text file. Python decodes at cold start with graceful fallback to external URL if the file can't be loaded.
Terraform PlanChanges detected — review required. Plan output |
LLM Plan ReviewRisk: 🟢 LOW Routine Lambda function updates with code changes and timeout adjustment, plus new ALB integration for password-set Lambda function.
|
Alexanderamiri
added a commit
that referenced
this pull request
May 9, 2026
## Summary - **Filter service-linked role noise** — Suppress `AWSServiceRoleFor*` events (ECS ENI provisioning) in slack-alert - **CI context in team provisioner** — Slack notifications now show who triggered the sync (actor, repo, commit, run link) - **Daily cost spike improvements** — $1 minimum threshold to filter noise, usage type + tag breakdown per spiking service, Cost Explorer links - **Weekly cost report tables** — Replace bullet-list mrkdwn with Block Kit tables (Service | Amount | % | WoW delta) - **Email branding** — Subject "Velkommen til JavaBin", footer "Javabrukerforeningen i Norge", salmon `#f05350` colors - **CID-embedded logo** — Logo PNG in repo, loaded from Lambda zip at cold start, falls back to external URL - **password.javazone.no** — ALB listener rule + Route53 record routes to password-set Lambda; handler supports both ALB and Function URL events ## Test plan - [ ] `terraform plan` — verify new resources (ALB target group, listener rule, Route53 record, SSM param update) - [ ] Trigger a test team provisioner sync and verify Slack shows CI context - [ ] Verify daily cost check filters small spikes (< $1) and shows usage type detail for real spikes - [ ] Verify weekly cost report renders Block Kit tables correctly - [ ] Confirm ECS ENI create/delete events no longer appear in #javabin-infra-alerts - [ ] Test password.javazone.no resolves and serves the password-set form - [ ] Verify welcome email renders with salmon branding and embedded logo (no Outlook trust prompt)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AWSServiceRoleFor*events (ECS ENI provisioning) in slack-alert#f05350colorsTest plan
terraform plan— verify new resources (ALB target group, listener rule, Route53 record, SSM param update)