Fix alert resource names for ELB and CI source attribution#72
Merged
Conversation
Resource names:
- Add extraction for ELB target groups, rules, listeners from nested
response structures (targetGroups[0].targetGroupName, etc.)
- Add fallback for request name/ARN fields
CI source:
- Extract run ID from session name convention (javabin-*-{run_id})
- Infer repo from role name (ci-infra → platform, ci-app-X → X)
- Builds GitHub Actions run link even when OIDC session tags are absent
Terraform Plan🚧 Changes detected — Plan: 0 to add, 2 to change, 0 to destroy. Plan outputLLM ReviewRisk: 🟢 LOW Routine Lambda function code updates for securityhub_summary and slack_alert with source code hash changes.
|
Alexanderamiri
added a commit
that referenced
this pull request
May 9, 2026
## Summary
- **ELB resource names**: Extract target group name, rule ARN, listener
ARN from nested CloudTrail response structures. Fixes "unknown" resource
name for CreateTargetGroup and CreateRule alerts.
- **CI source links**: Extract GitHub run ID from session name
convention (`javabin-*-{run_id}`), infer repo from role name (`ci-infra`
→ `javaBin/platform`, `ci-app-X` → `javaBin/X`). Alerts now show
clickable repo + run links even when OIDC session tags aren't in
CloudTrail.
## Test plan
- [ ] Next ELB change should show target group name instead of "unknown"
- [ ] CI-triggered alerts should show repo link + Actions run link
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
javabin-*-{run_id}), infer repo from role name (ci-infra→javaBin/platform,ci-app-X→javaBin/X). Alerts now show clickable repo + run links even when OIDC session tags aren't in CloudTrail.Test plan