Add CloudTrail and CI concurrency/lock-timeout#8
Merged
Conversation
Prevents state lock race when multiple pushes trigger CI simultaneously. Concurrency group queues runs; lock-timeout=5m waits instead of failing.
CloudTrail is required for EventBridge rules matching "AWS API Call via CloudTrail" to fire. Without it, resource creation, IAM change, and compliance alerts never trigger. Also adds concurrency group and lock-timeout=5m to platform-ci.yml to prevent state lock races when multiple pushes trigger CI simultaneously.
Alexanderamiri
force-pushed
the
fix/cloudtrail-and-ci-concurrency
branch
from
2fef3a0 to
74bcd97
Compare
Terraform PlanChanges detected — review required. Plan output |
🧠 LLM Plan ReviewRisk: 🟢 LOW Risk: 🟢 LOW Adding CloudTrail audit logging infrastructure with S3 bucket, lifecycle policies, and security controls for the Javabin AWS account.
|
Alexanderamiri
added a commit
that referenced
this pull request
Mar 8, 2026
## Summary - **CloudTrail moved to `terraform/org/`** — permission boundary blocks CI from managing it, applied manually alongside Identity Center - **CI concurrency group** — prevents state lock races on parallel pushes - **Lock timeout 5m** — waits instead of failing on lock contention - **`terraform fmt` replaces `fmt -check`** — auto-formats instead of failing - Removed CloudTrail from `terraform/platform/monitoring/` (was added in #8 but CI can't apply it) CloudTrail is already applied and logging.
Alexanderamiri
added a commit
that referenced
this pull request
May 9, 2026
## Summary - **CloudTrail trail**: Required for EventBridge rules to receive `AWS API Call via CloudTrail` events. Without this, resource creation, IAM change, and compliance alerts never fire. Single trail (free tier), management events only, logs expire after 90 days. - **CI concurrency group**: Prevents state lock races when multiple pushes trigger CI simultaneously. - **Lock timeout**: `terraform plan/apply` now waits 5 minutes for the lock instead of failing immediately. ## Test plan - [ ] CloudTrail trail created successfully - [ ] EventBridge rules start receiving API call events - [ ] Slack alerts fire on resource creation
Alexanderamiri
added a commit
that referenced
this pull request
May 9, 2026
## Summary - **CloudTrail moved to `terraform/org/`** — permission boundary blocks CI from managing it, applied manually alongside Identity Center - **CI concurrency group** — prevents state lock races on parallel pushes - **Lock timeout 5m** — waits instead of failing on lock contention - **`terraform fmt` replaces `fmt -check`** — auto-formats instead of failing - Removed CloudTrail from `terraform/platform/monitoring/` (was added in #8 but CI can't apply it) CloudTrail is already applied and logging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AWS API Call via CloudTrailevents. Without this, resource creation, IAM change, and compliance alerts never fire. Single trail (free tier), management events only, logs expire after 90 days.terraform plan/applynow waits 5 minutes for the lock instead of failing immediately.Test plan