fix(ci): make DockerHub publish conditional so the dev image builds on forks#690
Merged
javi11 merged 1 commit intoJun 15, 2026
Merged
Conversation
…n forks
The dev-image workflow logged in and pushed to DockerHub (laris11/altmount)
unconditionally, which fails on forks lacking DOCKERHUB_USERNAME/
DOCKERHUB_TOKEN secrets ("Username and password required"). Gate every
DockerHub step on the secrets being present: forks publish to GHCR only,
upstream still publishes to both.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dev-image workflow logged in and pushed to DockerHub (
laris11/altmount) unconditionally, which fails on forks that lack theDOCKERHUB_USERNAME/DOCKERHUB_TOKENsecrets ("Username and password required").This gates every DockerHub step on those secrets being present:
Changes
.github/workflows/dev-image.yml: conditionally run the DockerHub login and push steps based on secret availability.