automaintainer: search for and add new CLI tools as bundled plugins to supe…#2
automaintainer: search for and add new CLI tools as bundled plugins to supe…#2javimosch wants to merge 3 commits into
Conversation
|
Warning Review limit reached
More reviews will be available in 59 minutes and 36 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (16)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c096d424eb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| { "name": "input", "type": "string", "required": true, "description": "Input .d2 file path" }, | ||
| { "name": "output", "type": "string", "required": false, "description": "Output SVG file path (default: input.svg)" }, |
There was a problem hiding this comment.
In the sc-zig path, adapterConfig.positionalArgs is not used when executing exact commands; only args marked with "positional": true are emitted as bare CLI arguments (executor.parseArgDefs/buildFlagArgs). Because these D2 inputs are only listed in adapterConfig.positionalArgs, sc-zig d2 compile svg input.d2 output.svg drops input.d2 and output.svg and runs just d2, even though the D2 CLI manual expects input/output as positional operands. Please add positional: true to these args (and the same pattern in the other new positional wrappers) or make the commands passthrough.
Useful? React with 👍 / 👎.
| "adapterConfig": { | ||
| "command": "b3sum", | ||
| "baseArgs": ["--no-names"], |
There was a problem hiding this comment.
When callers pipe data to sc b3sum hash stdin, this wrapper runs in normal captured process mode rather than passthrough/stdin-forwarding mode; the Node process adapter uses stdin: "ignore" for captured commands, and the Zig adapter similarly captures output without inheriting stdin. As a result, b3sum --no-names receives EOF and returns the hash of empty input instead of the piped bytes. Please either forward stdin for this command or expose it through passthrough.
Useful? React with 👍 / 👎.
|
Approved by automaintainer review team — ready for human merge |
2 similar comments
|
Approved by automaintainer review team — ready for human merge |
|
Approved by automaintainer review team — ready for human merge |
|
Automaintainer Review Verdict: APPROVED Evaluation:
|
|
Automaintainer Approver: CHANGES_REQUESTED The reviewer identified the following issue:
External review notes (non-blocking, but worth addressing):
Please address the publish step issue and re-request review. |
|
Approved by automaintainer review team — auto-merging |
|
Automaintainer Review Verdict: APPROVED 4 well-structured plugins (d2, b3sum, git-absorb, mcfly) following existing conventions with proper plugin.json, meta.json, install-guidance.json, and skills/quickstart/SKILL.md files. External review concerns addressed:
CI failures: Pre-existing — |
|
Approved by automaintainer review team — auto-merging |
|
Automaintainer Approver: MERGE_FAILED — merge conflicts detected (CONFLICTING state). Requires manual conflict resolution before merging. |
d2: declarative diagram scripting language (Go, 18k+ stars) - Compile .d2 files to SVG, PNG, PDF - Supports watch mode, themes, multiple layout engines - Source: https://github.com/terrastruct/d2 b3sum: BLAKE3 cryptographic hash CLI (Rust, 5k+ stars) - Compute BLAKE3 hashes for files and streams - Multi-threaded, fast, secure - Source: https://github.com/BLAKE3-team/BLAKE3
git-absorb (tummychow/git-absorb) — auto-create fixup! commits for staged Git changes. Rust, 5.6k stars. mcfly (cantino/mcfly) — neural shell history search with smart ranking. Rust, 7.7k stars. Both follow the isolated plugin convention: plugin.json, meta.json, install-guidance.json, and skills/quickstart/SKILL.md.
- Make compile args consistent across svg/png/pdf (--target, --bundle, --font-*) - Align install-guidance.json test steps with plugin.json for both plugins
javimosch
force-pushed
the
am/am-0e131c-tftica
branch
from
c096d42 to
70eebdb
Compare
1 participant
Automated maintenance run by automaintainer.
Focus: search for and add new CLI tools as bundled plugins to supercli. For each plugin: search GitHub for non-interactive CLI tools (stars>100, rust/go/python), create plugin files (plugin.json, meta.json, install-guidance.json, skills/quickstart/SKILL.md), validate JSON, commit with conventional commit message. Target 2 plugins per session.
Branch:
am/am-0e131c-tftica