Skip to content

docs: document missing config.toml fields#44

Open
jaylfc wants to merge 2 commits into
mainfrom
docs/auto-freshness-20260704
Open

docs: document missing config.toml fields#44
jaylfc wants to merge 2 commits into
mainfrom
docs/auto-freshness-20260704

Conversation

@jaylfc

@jaylfc jaylfc commented Jul 4, 2026

Copy link
Copy Markdown
Owner

What's stale

Routine docs-freshness audit found three real Config fields (src/config.rs) that predate this fix but were never added to README's ## Configuration example block:

  • launch_maximized — toggled via Settings → Windows ("Launch maximized" row, settings.rs:388); affects new-window placement.
  • default_apps — the file-type → app handler map, editable via Settings → Default Apps (settings.rs:267,427); the feature itself was already documented in "What works today", just not the config key/shape.
  • desktop_enabled — gates whether desktop icons render (session.rs, multiple call sites); no Settings UI row exists for it, so the config example was the only place a user could discover it, and it wasn't there.

Fix

Added all three to the toml example in README.md with brief inline comments, matching the style of neighboring entries. Docs-only change; verified the updated example block still parses as valid TOML.

Scope check

launch_maximized (Settings -> Windows), default_apps (Settings -> Default
Apps), and desktop_enabled (config-only, no Settings row) are all real,
Settings-editable or user-facing Config fields that predate this fix but
were never added to the README's config.toml example.
@qodo-code-review

Copy link
Copy Markdown

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

@coderabbitai

coderabbitai Bot commented Jul 4, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@jaylfc, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 37 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 4f7028c6-bf4e-47b7-8f04-d0e4790e4759

📥 Commits

Reviewing files that changed from the base of the PR and between 8ea344d and ccfefcb.

📒 Files selected for processing (1)
  • README.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/auto-freshness-20260704

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@gitar-bot

gitar-bot Bot commented Jul 4, 2026

Copy link
Copy Markdown

Gitar is working

Gitar

Comment thread README.md Outdated
grid_cols = 3
tile_gap = 0
auto_tile = false
launch_maximized = false # new windows open maximized (Settings → Windows)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SUGGESTION: The comment reads "new windows open maximized" but the value is false, so a user copying this block as-is will get the opposite behavior of what the comment seems to describe. Consider wording that makes the boolean obvious, matching the style of nearby entries like assistant_mode = "panel" # "panel" (right-docked) | "window" (floating).

Suggested change
launch_maximized = false # new windows open maximized (Settings → Windows)
launch_maximized = false # true = new windows open maximized (Settings → Windows)

Reply with @kilocode-bot fix it to have Kilo Code address this issue.

@kilo-code-bot

kilo-code-bot Bot commented Jul 4, 2026

Copy link
Copy Markdown

Code Review Summary

Status: No Issues Found | Recommendation: Merge

The previous SUGGESTION on README.md:221 (misleading launch_maximized = false comment) was correctly addressed in the second commit — the comment now reads true = new windows open maximized, making the boolean obvious and matching the style of neighboring entries (e.g. assistant_mode). The first commit's added fields (launch_maximized, desktop_enabled, [default_apps]) remain in place and unchanged.

Files Reviewed (1 file)
  • README.md - 0 issues
Previous Review Summary (commit 3c0a2d1)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit 3c0a2d1)

Status: 1 Issue Found | Recommendation: Address before merge

Overview

Severity Count
CRITICAL 0
WARNING 0
SUGGESTION 1
Issue Details (click to expand)

SUGGESTION

File Line Issue
README.md 221 Inline comment on launch_maximized = false reads "new windows open maximized" without acknowledging the boolean — could mislead a reader into copying true while expecting false behavior.
Files Reviewed (1 file)
  • README.md - 1 issue

PR description and code claims verified against src/config.rs (lines 52, 73, 80, 131, 139, 141) and src/openwith.rs (line 125). All three documented fields exist, defaults shown in the example match the code defaults, and the TOML block parses correctly. Docs-only change is appropriately scoped.

Fix these issues in Kilo Cloud


Reviewed by minimax-m3 · Input: 20.9K · Output: 1K · Cached: 98.5K

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant