docs: warn the assistant that tuiui launch skips the CLI-tool wrapper#46
docs: warn the assistant that tuiui launch skips the CLI-tool wrapper#46jaylfc wants to merge 2 commits into
Conversation
Routine docs-freshness audit: agent/DESKTOP.md tells the assistant to run `tuiui launch <command>`, but that path (ClientMsg::Launch -> launch() in session.rs) spawns the bare command directly and never calls cli_wrap. The help-then-shell wrapper added for CLI-tagged catalog tools (commit 2a01eca) only fires through the launcher menu/Spotlight/Store UI paths, so an assistant-driven `tuiui launch gum` (or any of the ~52 "cli": true entries) still opens a window that prints usage and exits immediately - the exact bug that feature was built to fix, just on a different launch path. Documents the gap and the working workaround (wrap the command in `sh -lc '<bin> --help; exec "$SHELL"'` before passing it to tuiui launch) so the assistant doesn't hit it. The underlying gap in the launch() path itself is a code fix, out of scope here.
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
|
Warning Review limit reached
Next review available in: 57 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. 📝 WalkthroughWalkthroughThis change adds documentation to agent/DESKTOP.md, clarifying that catalog entries tagged as CLI tools print usage and exit when launched directly, and provides an alternate command to obtain an interactive shell. ChangesDocumentation update
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
Code Review SummaryStatus: No Issues Found | Recommendation: Merge The previous incremental review flagged two issues on
Both were addressed in commit Files Reviewed (1 file)
Previous Review Summary (commit d84756a)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit d84756a)Status: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Files Reviewed (1 file)
Reviewed by minimax-m3 · Input: 20.3K · Output: 1K · Cached: 101.4K |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@agent/DESKTOP.md`:
- Line 11: The example in DESKTOP.md should match the real shell fallback used
by cli_wrap, which relies on exec "${SHELL:-sh}" rather than exec "$SHELL".
Update the launch example referenced by tuiui launch sh -lc so it shows the
fallback behavior correctly and uses the same shell invocation pattern as
cli_wrap, ensuring the docs reflect the interactive shell fallback when SHELL is
unset.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
|
|
…'s shell fallback
Review feedback on the CLI-launch escape-hatch example: the <bin> placeholder
would be interpreted literally if pasted verbatim (sh: 1: <bin>: not found),
and exec "$SHELL" doesn't match cli_wrap's actual exec "${SHELL:-sh}" fallback
for when $SHELL is unset. Swapped in a concrete example (gum) with a
substitute-the-binary note, and fixed the shell invocation to mirror cli_wrap.
1 participant
What's stale
Routine docs-freshness audit found
agent/DESKTOP.mddescribingtuiui launch <command> [args…]with no caveat about CLI-tagged catalog tools (the ~52 entries with"cli": true— gum, himalaya, khal, dust, …).Traced the code: the help-then-shell wrapper added in commit 2a01eca (
cli_wrap,sh -lc '<bin> --help; exec "$SHELL"') is only applied by the launcher-menu/Spotlight/Store UI paths (launch_entry/store_activateinsrc/session.rs). TheClientMsg::Launchhandler thattuiui launchsends (src/main.rs→session.rs::launch/launch_in) spawns the bare command directly and never callscli_wrap. So an assistant-driventuiui launch gumstill opens a window that prints usage and exits immediately — the exact bug the CLI-tools feature was built to fix, just reachable through a different launch path.Fix
Added a note to
agent/DESKTOP.mddocumenting the gap and the workaround: wrap the command insh -lc '<bin> --help; exec "$SHELL"'before passing it totuiui launch.Scope check
agent/DESKTOP.mdonly.ClientMsg::Launchpath not callingcli_wrap) is a real code-level inconsistency, out of scope for a docs-only fix — flagging it separately for a proper fix insession.rs.Generated by Claude Code
Summary by CodeRabbit