fix: use 'qmd collection list' for qmd detection#15
Merged
Conversation
'qmd status' can trigger slow model/device probing (e.g. Vulkan fallback) that exceeds the 5s timeout on some systems, causing detectQmd() to return false and the install banner to appear even when qmd is installed and healthy. Switch to the lighter 'qmd collection list' probe and raise the timeout to 15s for headroom. Fixes #10 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> Signed-off-by: Jay Zeng <jayzeng@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
qmd statusprobe indetectQmd()withqmd collection list, which doesn't trigger the slow model/device probe code path (e.g. Vulkan fallback) on some systems.On affected systems
qmd statuswas taking 10–20s, blowing past the 5s timeout and producing a false negative. That caused the install banner to appear at every startup andmemory_searchto report qmd was unavailable — despite qmd being installed and healthy.checkCollection()already usesqmd collection listin the same file, so the lighter probe is known-good.Fixes #10
Test plan
bun test/e2e.tspasses (6 passed, 5 skipped due to no qmd in env)biome checkpassesqmd statusis slow: banner no longer shown,memory_searchworks🤖 Generated with Claude Code