Raise TypeError for invalid Dataset instance#649
Open
koteshyelamati wants to merge 1 commit into
Open
Conversation
stack() and stack_cols() currently return None silently when passed a non-Dataset argument. This can hide bugs since callers get None back and may not notice the operation failed. This commit raises TypeError with a clear message instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
stack()andstack_cols()silently returnNonewhen passed a non-Datasetargument:This makes bugs very hard to diagnose: callers receive
Nonewithout any indication that the argument was invalid.Fix
Raise
TypeErrorwith a clear message instead of silently returningNone.