fix: use Njord instead of dead plugin and service#16
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR updates pom.xml: adds inceptionYear, replaces SCM and distributionManagement with GitHub and Sonatype Central Portal entries (including snapshot repo), integrates Njord (properties, pluginManagement entry, and build extension), and bumps the integration-test groovy-all dependency. ChangesPublishing and Build Configuration
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
OSSRH is gone, and Sonatype CP is the new thing to publish
cstamas
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@pom.xml`:
- Around line 49-64: The distributionManagement repository ids don't match the
CI's server id so Maven will fail authentication; update the <id> values under
distributionManagement repository and snapshotRepository from
sonatype-central-portal to ossrh (i.e. change the repository id and
snapshotRepository id to "ossrh") so they match the CI workflow's server-id, or
alternatively update the CI workflow's server-id to "sonatype-central-portal" if
you prefer to keep the current pom; locate the distributionManagement block
(repository, snapshotRepository) to make the change, ensuring the ids align with
the server id used in the CI settings.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
| <distributionManagement> | ||
| <repository> | ||
| <id>sonatype-central-portal</id> | ||
| <name>Sonatype Central Portal</name> | ||
| <url>https://repo.maven.apache.org/maven2/</url> | ||
| </repository> | ||
| <snapshotRepository> | ||
| <id>sonatype-central-portal</id> | ||
| <name>Sonatype Central Portal</name> | ||
| <url>https://central.sonatype.com/repository/maven-snapshots/</url> | ||
| </snapshotRepository> | ||
| <site> | ||
| <id>github</id> | ||
| <url>${project.scm.connection}</url> | ||
| </site> | ||
| </distributionManagement> |
There was a problem hiding this comment.
Server ID mismatch will cause deploy authentication failure.
The repository <id>sonatype-central-portal</id> does not match the CI workflow's credential configuration. In .github/workflows/ci.yml:52, credentials are configured with server-id: ossrh. Maven resolves credentials by matching the repository id to the server id in settings.xml—this mismatch means deploy will fail to authenticate.
Either update the repository ids here to ossrh, or update the CI workflow to use server-id: sonatype-central-portal.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@pom.xml` around lines 49 - 64, The distributionManagement repository ids
don't match the CI's server id so Maven will fail authentication; update the
<id> values under distributionManagement repository and snapshotRepository from
sonatype-central-portal to ossrh (i.e. change the repository id and
snapshotRepository id to "ossrh") so they match the CI workflow's server-id, or
alternatively update the CI workflow's server-id to "sonatype-central-portal" if
you prefer to keep the current pom; locate the distributionManagement block
(repository, snapshotRepository) to make the change, ensuring the ids align with
the server id used in the CI settings.
2 participants
OSSRH is gone, and Sonatype CP is the new thing to publish. Use Njord and nothing changes in release process.
Summary by CodeRabbit
Chores
Dependencies