add bitsquat detection script#3
Open
hkparker wants to merge 1 commit into
Open
Conversation
hkparker
commented
May 27, 2016
hkparker
commented
|
|
||
| def is_valid_domain_char(original, char) | ||
| return false if char == original - 32 | ||
| return (65 <= char && char <= 90) || (97 <= char && char <= 122) || (char == 45) |
Owner
There was a problem hiding this comment.
You forgot to include the ASCII range for numbers [0-9].
These can be in domains.
Also do you need both upper and lowercase? I assume that your browser, for example, would also just downcase! everything before submitting it to DNS. Perhaps even a machines kernal will do that before a network call? But probably good to account for the case where you bitflip from a into B while the packet is traveling to DNS - I assume that DNS will then downcase everything.
Owner
|
This is sick |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.