Skip to content

[GHA] performance workflow requires JDK 25#238

Merged
mmusgrov merged 1 commit into
jbosstm:mainfrom
mmusgrov:gha-wf-dispatch
Jul 6, 2026
Merged

[GHA] performance workflow requires JDK 25#238
mmusgrov merged 1 commit into
jbosstm:mainfrom
mmusgrov:gha-wf-dispatch

Conversation

@mmusgrov

@mmusgrov mmusgrov commented Jul 6, 2026

Copy link
Copy Markdown
Member

[GHA] require JDK 25 when manually triggering a performance run

pr/237 added a manual trigger for performance run but it should have constrained the JDK to use Java 25

NO_TESTS

@coderabbitai

coderabbitai Bot commented Jul 6, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: aae89014-801d-414d-b5d6-6c71f74e141d

📥 Commits

Reviewing files that changed from the base of the PR and between 895af82 and 91183d9.

📒 Files selected for processing (1)
  • .github/workflows/performance.yml

📝 Walkthrough

Walkthrough

The GitHub Actions workflow file performance.yml is updated to change the jdk_version input for workflow_dispatch, reducing the available options from ['21','17','11'] to only '25', and updating the default value to '25'.

Changes

CI Workflow JDK Version Update

Layer / File(s) Summary
JDK version input update
.github/workflows/performance.yml
The jdk_version workflow_dispatch input's options list and default value are changed to a single option, '25'.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is very brief and does not follow the repository template or list the required workflow variables and JDK selection details. Expand the PR description to match the template, including the environment variables section and the JDK selection note for 17, 21, and 25.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the change: the performance workflow is being constrained to JDK 25.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mmusgrov
mmusgrov requested a review from marcosgopen July 6, 2026 14:10

@marcosgopen marcosgopen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Mike

@mmusgrov
mmusgrov merged commit 2c4e9ac into jbosstm:main Jul 6, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants