Skip to content

Added support for stores that already have lat and lng TVs #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
watou wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Added support for stores that already have lat and lng TVs #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2e8196d
Added support for stores that already have lat and lng TVs to avoid u…
watou Mar 26, 2019
fd173ad
The message should have access to the radius used.
watou Mar 26, 2019
11b8d69
Add contains operator to where clause to include location if substrin…
watou Mar 29, 2019
2483820
Updated readme.md with new properties.
watou Mar 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions core/components/googlestorelocator/elements/snippets/googlestorelocator.snippet.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@

// Configuration parameters
$config['parents'] = array_unique(explode(',', $modx->getOption('parents', $scriptProperties, $modx->resource->get('id'), true)));
$config['tvname_lat'] = $modx->getOption('tvNameLat', $scriptProperties, 'gslLat', true);
$config['tvname_lng'] = $modx->getOption('tvNameLng', $scriptProperties, 'gslLng', true);
$config['tvname_zipcode'] = $modx->getOption('tvNameZipcode', $scriptProperties, 'gslZipcode', true);
$config['tvname_city'] = $modx->getOption('tvNameCity', $scriptProperties, 'gslCity', true);
$config['tvname_street'] = $modx->getOption('tvNameStreet', $scriptProperties, 'gslStreet', true);
Expand Down
8 changes: 8 additions & 0 deletions core/components/googlestorelocator/model/googlestorelocator/googlestorelocator.class.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ public function __construct(MODX $modx, array $config = array())
$this->apikeyServer = $this->modx->getOption('googlestorelocator.apikey_server');
$this->apikeyMap = $this->modx->getOption('googlestorelocator.apikey_map');
$this->parents = $config['parents'];
$this->tvname_lat = $config['tvname_lat'];
$this->tvname_lng = $config['tvname_lng'];
$this->tvname_street = $config['tvname_street'];
$this->tvname_housenumber = $config['tvname_housenumber'];
$this->tvname_zipcode = $config['tvname_zipcode'];
Expand Down Expand Up @@ -97,6 +99,8 @@ public function getStores()
$store = array(
'id' => $item->id,
'name' => $item->pagetitle,
'lat' => $page->getTVValue($this->tvname_lat),
'lng' => $page->getTVValue($this->tvname_lng),
'street' => $page->getTVValue($this->tvname_street),
'housenumber' => $page->getTVValue($this->tvname_housenumber),
'zipcode' => $page->getTVValue($this->tvname_zipcode),
Expand Down Expand Up @@ -238,6 +242,7 @@ public function setLocation($stores)
if (!empty($_REQUEST['location'])) {
$message = $this->modx->getChunk($this->tpl_message, array(
'address' => $locationData['address'],
'radius' => $radius,
));

$this->modx->toPlaceholders(array(
Expand Down Expand Up @@ -304,6 +309,9 @@ public function filterStores($stores, $key, $value, $operator = '<=')

$stores = array_filter($stores, function ($var) {
switch ($this->operator) {
case 'contains':
return strpos($var[$this->key], $this->value) !== false;
break;
case '==':
case '=':
return ($var[$this->key] == $this->value);
Expand Down
3 changes: 3 additions & 0 deletions readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ Since the latest version of Google-API: API-KEY(s) are required! Create a API-KE
| &tvNameHousenumber | gslHousenumber | Name of the TV holding the Housenumber of the Store. |
| &tvNameState | gslState | Name of the TV holding the State of the Store. |
| &tvNameCountry | gslCountry | Name of the TV holding the Country of the Store. |
| &tvNameLat | gslLat | Name of the TV holding the Latitude of the Store (to skip geocoding). |
| &tvNameLng | gslLng | Name of the TV holding the Longitude of the Store (to skip geocoding). |
| &includeTVs | | Comma-separated list of TVs that should be included in the placeholders available to each store template. Example: "storename,time" will produce the placeholders and . |
| &tvPrefix | tv. | Prefix TV property. |
| &unit | K | Options: K = kilometers / M = miles / N = nautical |
Expand Down Expand Up @@ -124,6 +126,7 @@ If you have more than 50 stores the initail rendering of all stores will take a
I tested the extra with about 1500 stores. The first rendering took about 4 refreshes and 1 Minute in between every refresh. After that: everything runs smooth.
Change a store/resource in the manager will delete this store from the cache and will be rewritten after the next request of the StoreLocation snippet. This won't take long, because it is just rendering the new added or changed stores.
If you manually clear the complete site-cache it also clears the GoogleStoreLocator cache and it needs a new rendering of all stores.
If your store resources already have latitude and longitude TVs, specify them with the `&tvNameLat` and `&tvNameLng` properties to skip the overhead of geocoding the addresses.

# Upgrading from Version 1.x to 2.x
Upgrading from Version 1.x to 2.x needs some little Changes in the propertie-setup.
Expand Down