enhance: rewrite regex generator in TypeScript#14
Open
kakkokari-gtyih wants to merge 1 commit into
Open
Conversation
Author
|
I misread #2 and mistakenly thought the goal was to rewrite the regex generator in TypeScript (it is actually JS+Flow), my bad. I rewrote it in TypeScript in this PR, but how should I proceed? Should I rewrite it with flow? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
As discussed in #2, migrating regex generator to Flow (JavaScript) is a long-term goal for this project. Regex generator is written in Scala, which makes it harder to contribute, especially by JS/TS ecosystem developers.
Solution
This pull request rewrites the regex generator from Scala to TypeScript.
At this moment, I am not working on converting other parts or modernizing the build steps (e.g. get rid of Mustache). However, if that's a better option, I can work on that too (depending on my personal schedule, though)
Result
The generated regex is identical to the current latest version (check that there are no differences in the regex part of regex.js).