Skip to content

enhance: rewrite regex generator in TypeScript#14

Open
kakkokari-gtyih wants to merge 1 commit into
jdecked:mainfrom
kakkokari-gtyih:enh-2
Open

enhance: rewrite regex generator in TypeScript#14
kakkokari-gtyih wants to merge 1 commit into
jdecked:mainfrom
kakkokari-gtyih:enh-2

Conversation

@kakkokari-gtyih

@kakkokari-gtyih kakkokari-gtyih commented Jun 28, 2026

Copy link
Copy Markdown

Problem

As discussed in #2, migrating regex generator to Flow (JavaScript) is a long-term goal for this project. Regex generator is written in Scala, which makes it harder to contribute, especially by JS/TS ecosystem developers.

Solution

This pull request rewrites the regex generator from Scala to TypeScript.

At this moment, I am not working on converting other parts or modernizing the build steps (e.g. get rid of Mustache). However, if that's a better option, I can work on that too (depending on my personal schedule, though)

Result

The generated regex is identical to the current latest version (check that there are no differences in the regex part of regex.js).

@kakkokari-gtyih

kakkokari-gtyih commented Jun 28, 2026

Copy link
Copy Markdown
Author

I misread #2 and mistakenly thought the goal was to rewrite the regex generator in TypeScript (it is actually JS+Flow), my bad.

I rewrote it in TypeScript in this PR, but how should I proceed? Should I rewrite it with flow?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant