Conversation
PR criteo#195 (runtime binary name) made the compile-time appName a near-unused fallback — users get the binary name from the file they run, not from the linker. Building both 'cdt' and 'cola' artifacts no longer makes sense for the fork, and the cdt build shipped 'Criteo Dev Toolkit' as its long name, which contradicts the fork notice. Changes: main.go: appName 'cdt' -> 'cola' appLongName 'Criteo Dev Toolkit' -> 'Command Launcher' build.sh: same defaults go.yml: drop cdt build line, cdt upload step, cdt rename and cdt entry in tag-release files; in the packaging job, switch every cdt artifact name and rename to cola; zip becomes cola_VERSION.zip. Not touched: CDT_VAULT_SECRET env var. internal/gvault/file-vault.go still reads that exact string literally — the framework-vs-app prefix split is a separate design call (tracked).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR criteo#195's runtime binary name made the compile-time
appNamea near-unused fallback (only fires ifos.Executable()errors). Continuing to ship two binaries that differ in nothing except a hardcoded fallback string doesn't serve the fork — and thecdtbuild shipped "Criteo Dev Toolkit" as its long name, which actively contradicts the fork notice we just added.This consolidates to one binary:
cola.Changes:
main.go—appNamefallback"cdt" → "cola",appLongName"Criteo Dev Toolkit" → "Command Launcher".build.sh— same defaults flipped..github/workflows/go.yml:build.shline, keep only cola.cola_${ref_name}.zip.Not touched in this PR:
CDT_VAULT_SECRETenv var in the workflow stays.internal/gvault/file-vault.go:157reads that exact string literally regardless of binary name. Until the env var split design call is made, the literal has to match.Test plan
go vet ./...clean locallygo test ./...passes locally./build.shwith no args produces acolabinary (wascdt)cola_*binaries (verified by absence of cdt artifacts in the release page)