This repository was archived by the owner on Apr 18, 2026. It is now read-only.
Refactor build configuration and improve error handling#15
Merged
jdolan merged 2 commits intojdolan:mainfrom Mar 25, 2026
Merged
Refactor build configuration and improve error handling#15jdolan merged 2 commits intojdolan:mainfrom
jdolan merged 2 commits intojdolan:mainfrom
Conversation
Refactor build configuration and enhance HTTP client
…ate sync method in Manager to use concatMap for better handling of emissions.
jdolan
reviewed
Mar 25, 2026
| */ | ||
| public Observable<File> sync(final Observable<Delta> deltas) { | ||
| return deltas.flatMap(delta -> delta.getIndex().getSync().sync(delta)) | ||
| return deltas.concatMap(delta -> delta.getIndex().getSync().sync(delta)) |
Owner
There was a problem hiding this comment.
You're de-parallelizing this chain here. Is there any reason why? Just to have better clarity between binaries vs data or? I get that each sync() will run N requests in parallel...
jdolan
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
some fixxes