Add time pretty-printing functionality when calling ._print() on any PrettyTime object#12
Open
sweep-ai-deprecated[bot] wants to merge 4 commits intomasterfrom
Open
Add time pretty-printing functionality when calling ._print() on any PrettyTime object#12sweep-ai-deprecated[bot] wants to merge 4 commits intomasterfrom
sweep-ai-deprecated[bot] wants to merge 4 commits intomasterfrom
Conversation
sweep-ai-deprecated
bot
added
the
sweep
Open
2 tasks
wwzeng1
reviewed
Aug 15, 2023
prettytime.py
Outdated
| self.today = datetime.datetime.today() | ||
|
|
||
| def _print(self): | ||
| time_units = [attr for attr in dir(self) if attr in self.TIME_LIST and getattr(self, attr) != 0] |
There was a problem hiding this comment.
use this logic in print instead:
if datetime.datetime.today() < self.today:
return str(self.num) + " " + self.attr + " from now"
else:
return str(self.num) + " " + self.attr + " ago"
wwzeng1
reviewed
Aug 15, 2023
prettytime.py
Outdated
| if datetime.datetime.today() < self.today: | ||
| return str(self.num) + " " + self.attr + " from now" | ||
| else: | ||
| return str(self.num) + " " + self.attr + " ago" |
There was a problem hiding this comment.
fix the duplicate in this function and also add the case when the time is today
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the functionality to pretty-print time when calling the ._print() method on any PrettyTime object. It introduces a new method, ._print(), in the parent class (t) that handles the pretty-printing of time. This method returns a string representation of the PrettyTime object in a human-readable format.
Summary
Fixes #11.
To checkout this PR branch, run the following command in your terminal:
To get Sweep to edit this pull request, leave a comment below or in the code. Leaving a comment in the code will only modify the file but commenting below can change the entire PR.