Security Review — 2026-07-08 — security-warning#137
Open
jdrumgoole wants to merge 1 commit into
Open
Conversation
3 WARNING findings: secondary Wine lookups in export/transaction views missing owner_id filter (WARN-1/2/3). 2 new INFO findings: Pillow CVEs (INFO-38) and update_one defence-in-depth (INFO-39). 37 INFO carried forward. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PTKbdDdHseAP7G7u1c6aRv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Daily security review for 2026-07-08. 3 WARNING findings identified by a deeper owner_id data isolation audit.
WARNING findings (3)
winebox/routers/export.py:250— Wine lookup inexport_transactionsmissingowner_idfilterwinebox/services/cellar_event_view.py:179— Bulk Wine lookup inlist_events_as_transactionsmissingowner_idfilterwinebox/services/cellar_event_view.py:219— Single Wine lookup inget_event_as_transactionmissingowner_idfilterAll three are secondary lookups where the wine_ids are derived from owner-scoped data. MongoDB ObjectIds are globally unique, so exploitation requires data corruption. However, these violate the project's stated security policy that all user data queries must filter by
owner_id.New INFO findings (2)
update_onecalls that don't re-assert owner_id in the filter (defence-in-depth)Carried forward
Top 3 priorities
owner_idto three query filtersFull report:
docs/security-reports/2026-07-08.mdGenerated by Claude Code