Support subgroup#5
Open
bapt wants to merge 1 commit into
Open
Conversation
Owner
|
I agree with the need for this feature. Related feature: https://lists.galene.org/galene/87ikrvfzdm.wl-jch@irif.fr I have two minor objections to your patch:
|
if AllowedSubGroups is defined, then walk down the request path timiing each time after the last '/' up to the point where a valid group is found.
Author
|
new attempt, trying to address your comments |
Owner
|
I think it needs more thought. Right now, it's an all-or-nothing option, it's not possible to set some groups to allow subgroups and not others. I'm sure it solves your immediate need, but I think we need a more general solution. I'm a little worried about the You still have O(n) behaviour in the allowSubgroups case. You need to do something like (I didn't check the details): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By matching the group name with globs, it allows users to define valid groups the following way:
groups: [ "groups/*" ]
to allow subgroup to work