Unified copy#136
Closed
CxRes wants to merge 4 commits into
Closed
Conversation
Changed the cjs require statements to esm imports at the top of the file for consistency. Moved solid-namespace from depDependencies to dependencies in Package.json
The new `copy` function unifies both `copyFile` and `copyFolder`. It determines whether the source is a file or folder from the network response (without the need for an extra network request) instead of the trailing slash on provided source url.
Reuses prior get and put responses to get links for copying. This saves unnecessary multiple head calls being made to fetch links.
Contributor
Author
|
There are few linting errors on my part and a couple of typos (It seems the original was not linted either). I'll PR a clean version merging into master. |
Owner
|
I am recovering from eye surgery and not able to get to these suggestions at the moment. @CxRes thanks for your ongoing contributions. @bourgeoa if you want to merge or otherwise change anything, please go ahead. OTOH, do not feel obligated to. I will look at all this more carefully in a couple of weeks. |
Contributor
Author
|
@jeff-zucker We can discuss this when you feel better. Hope you get well soon!!! |
Contributor
Author
|
Please look at #138 instead, which is a more comprehensive PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have created a unified copy function that works for files and folders:
I have kept the logic absolutely unchanged, only rearranged and optimized the code. Fingers crossed nothing should break. Old functionality is untouched!
I am unable to run tests on my windows machine - unrelated tests keep failing. Hence the draft PR, so that hopefully someone else can test this before merging.