Conversation
jeffijoe
force-pushed
the
feat/cultureinfo
branch
2 times, most recently
from
ac11a87 to
4993bd2
Compare
jeffijoe
force-pushed
the
feat/cultureinfo
branch
from
4993bd2 to
eac9acd
Compare
Owner
Author
|
@glen-84 @NightOwl888 It took a few years but we did it! Please take a look, let me know if there's anything we should change. @sfuqua, as a recent contributor who did some fantastic work and has familiarized yourself with the code, I would love it if you would take a look as well. |
sfuqua
approved these changes
Feb 23, 2026
Contributor
sfuqua
left a comment
sfuqua
left a comment
There was a problem hiding this comment.
lgtm overall! I'm on the fence about the CultureInfo vs string comment I left - I see some real value in exposing a way to call FormatMessage() with either ` string or a parsed Culture and it'd provide an escape hatch for inconsistencies between the Framework the CLDR data shipped with the package, if you can stomach having IFormatter needing to support it as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the default culture to
CurrentCulture, adds aCultureInfo? culture = nullparameter toFormatMessage, and upgrades the build targeting tonet10, droppingnet6. Also migrated from Source Generator to Incremental Generator API for the plural rules generator, as well as updated packages.These are all breaking changes.
Closes #41