Added support for TRACE32 parser and metrics#662
Added support for TRACE32 parser and metrics#662IgorMiksza wants to merge 11 commits intojenkinsci:mainfrom
Conversation
There was a problem hiding this comment.
This needs to be the matching incrementals version of the coverage model:
Deployed version 0.66.0-rc1266.b_e6b_17a_f3c2c to Incrementals
There was a problem hiding this comment.
This needs to be the matching incrementals version of the coverage model:
Deployed version 0.66.0-rc1266.b_e6b_17a_f3c2c to Incrementals
Version bumped, thanks :)
Added `Metric.INSTRUCTION` to ViewModel, TableModel, Summary, Overview Updated results tests for Coverage Publisher Overview and Summary
IgorMiksza
force-pushed
the
trace32-coverage
branch
from
543e641 to
1d25de4
Compare
uhafner
left a comment
uhafner
left a comment
There was a problem hiding this comment.
Can we find a way to not change the views for existing users?
| Metric.MCDC_PAIR, Metric.FUNCTION_CALL, | ||
| // TRACE32 metrics | ||
| Metric.STMT_CC, Metric.STMT_DC, Metric.CONDITION, Metric.BYTES | ||
| )); |
There was a problem hiding this comment.
Do you really want all new metrics to appear in the summary?
| Set.of(Metric.LINE, Metric.LOC, Metric.BRANCH, Metric.INSTRUCTION, | ||
| Metric.CYCLOMATIC_COMPLEXITY, Metric.MUTATION, Metric.TEST_STRENGTH, | ||
| Metric.TESTS, Metric.MCDC_PAIR, Metric.FUNCTION_CALL, | ||
| Metric.STMT_DC, Metric.STMT_CC, Metric.CONDITION, Metric.BYTES)); |
There was a problem hiding this comment.
The same here: a summary is there to show the most important things only.
| configureValueColumn("instructionCoverage", Metric.INSTRUCTION, Messages.Column_InstructionCoverage(), | ||
| Messages.Column_DeltaInstructionCoverage("Δ"), columns); |
There was a problem hiding this comment.
This one in not helpful for most of the people
| Metric.LINE, Metric.BRANCH, Metric.INSTRUCTION, Metric.MUTATION, Metric.TEST_STRENGTH, Metric.CYCLOMATIC_COMPLEXITY, | ||
| Metric.TESTS, Metric.MCDC_PAIR, Metric.FUNCTION_CALL, Metric.COGNITIVE_COMPLEXITY, Metric.NCSS, Metric.NPATH_COMPLEXITY, | ||
| Metric.STMT_DC, Metric.STMT_CC, Metric.CONDITION, Metric.BYTES); |
There was a problem hiding this comment.
I think we need to make these things configurable. It makes no sense to show all of these for everyone.
| No changes detected, that affect the code coverage. | ||
| * Line Coverage: 91.02% (294/323) | ||
| * Branch Coverage: 93.97% (109/116) | ||
| * Instruction Coverage: 93.33% (1260/1350) |
There was a problem hiding this comment.
This changes existing behavior and should be reverted, see comment above
|
|
||
| <!-- Library Dependencies Versions --> | ||
| <coverage-model.version>0.66.0</coverage-model.version> | ||
| <coverage-model.version>0.67.0-rc1288.7c1e4750a_8b_a_</coverage-model.version> |
There was a problem hiding this comment.
This is not needed anymore. The best thing is to merge with main (or rebase).
2 participants
Hello, I've added support for TRACE32 parser and metrics that include Statement, Decision, Condition, Function, Object Code and Bytes coverages.
I've added our metrics to
CoverageTrendChart,CoverageBuildAction,CoverageChecksPublisher,CoverageTableModel,CoverageViewModelandMessages.properties.I've also added TRACE32 to
README.md,pom.xmldescription,CoverageTool.javaandMessages.properties.An example of our reports can be found in the coverage-model pull request.